Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Minor fixes and split pre-release workflow into 2 separate workflows. #1257

Merged

Conversation

AjayJagan
Copy link
Contributor

Description

  1. Add "v" in the pushed tag(quay).
  2. Add logic to remove duplicate entries(read from tracker) in the release notes.
  3. Split pre-release workflow into 2 separate workflows. This is done to eliminate the need to retrigger whole workflow when the e2e fails.
  4. Remove wait-for-checks.sh script as we no longer need to wait for e2e and we can manually trigger the next workflow.

How Has This Been Tested?

Tested by running gh actions in my repo.
https://github.com/AjayJagan/opendatahub-operator/actions/runs/10936169592
https://github.com/AjayJagan/opendatahub-operator/actions/runs/10936181720

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

  1. Add "v" in the pushed tag(quay).
  2. Add logic to remove duplicate entries(read from tracker) in the release notes.
  3. Split pre-release workflow into 2 separate workflows. This is done to eliminate the need to
     retrigger whole workflow when the e2e fails.
  4. Remove wait-for-checks.sh script as we no longer need to wait for e2e and we can manually trigger the next workflow.
@AjayJagan
Copy link
Contributor Author

@VaishnaviHire ^

Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ace0ead into opendatahub-io:incubation Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants