Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup code #1238

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Sep 16, 2024

Description

  • no need to add ingresscontroller into runtime again
  • it has been handled in main.go
    utilruntime.Must(operatorv1.Install(scheme))

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- no need to add ingresscontroller into runtime again
- it has been handled in main.go

Signed-off-by: Wen Zhou <[email protected]>
@zdtsw zdtsw requested review from VaishnaviHire and removed request for StevenTobin September 16, 2024 15:52
Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member Author

zdtsw commented Sep 16, 2024

/test opendatahub-operator-e2e

@openshift-merge-bot openshift-merge-bot bot merged commit ac7bb50 into opendatahub-io:incubation Sep 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants