chore: get_all_manifests.sh: support tags and make it priority #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykaliuta
force-pushed
the
manifests-branch
branch
4 times, most recently
from
4921fb0
to
ad65664
Compare
|
@ykaliuta Can you add |
ykaliuta
changed the title
ykaliuta
force-pushed
the
manifests-branch
branch
from
ad65664
to
c7fdf46
Compare
yes. But I'm wondering, how it helps? |
|
+1 from me |
zdtsw
reviewed
Aug 21, 2024
get_all_manifests.sh
Outdated
| if ! $git_fetch refs/tags/$ref 2>/dev/null ; then | ||
| $git_fetch refs/heads/$ref | ||
| fi | ||
| git reset --hard FETCH_HEAD |
There was a problem hiding this comment.
Suggested change
| git reset --hard FETCH_HEAD | |
| git reset -q --hard FETCH_HEAD |
to suspend checkout commit
There was a problem hiding this comment.
to suspend checkout commit
As you wish :)
Jira: https://issues.redhat.com/browse/RHOAIENG-11687 Current script is supposed to be used with branches since it uses "git clone -b" while preparing tagged releases it is useful to fetch tags. "git clone -b" can work with tags as well, but if the same name branch exists it fetches the branch which is not desireable behaviour if tagged release is being produced. Try to fetch tag. If it fails fallback to branch. GitHub discussion: opendatahub-io#1169 (comment) Signed-off-by: Yauheni Kaliuta <[email protected]>
ykaliuta
force-pushed
the
manifests-branch
branch
from
c7fdf46
to
512ab4b
Compare
zdtsw
approved these changes
Aug 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ykaliuta Thanks for tagging me. I didn't know the tags would be used back when writing the script (or adjusting the existing one), so I'm happy it has been improved. Pinned versions should help in some weird errors I've seen in the past with misaligned "release" branches. |
openshift-merge-bot
bot
merged commit d2caf7a
into
opendatahub-io:incubation
8 checks passed
zdtsw
pushed a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Aug 29, 2024
…atahub-io#1194) Jira: https://issues.redhat.com/browse/RHOAIENG-11687 Current script is supposed to be used with branches since it uses "git clone -b" while preparing tagged releases it is useful to fetch tags. "git clone -b" can work with tags as well, but if the same name branch exists it fetches the branch which is not desireable behaviour if tagged release is being produced. Try to fetch tag. If it fails fallback to branch. GitHub discussion: opendatahub-io#1169 (comment) Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit d2caf7a)
openshift-merge-bot bot
pushed a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Aug 30, 2024
…atahub-io#1194) Jira: https://issues.redhat.com/browse/RHOAIENG-11687 Current script is supposed to be used with branches since it uses "git clone -b" while preparing tagged releases it is useful to fetch tags. "git clone -b" can work with tags as well, but if the same name branch exists it fetches the branch which is not desireable behaviour if tagged release is being produced. Try to fetch tag. If it fails fallback to branch. GitHub discussion: opendatahub-io#1169 (comment) Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit d2caf7a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/RHOAIENG-11687
Current` script is supposed to be used with branches since it uses "git clone -b" while preparing tagged releases it is useful to fetch tags. "git clone -b" can work with tags as well, but if the same name branch exists it fetches the branch which is not desirable behaviour if tagged release is being produced.
Try to fetch tag. If it fails fallback to branch.
GitHub discussion: #1169 (comment)
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria