chore: cleanup annotation in CSV #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
requested review from
lburgazzoli and
ykaliuta
and removed request for
adelton
- we do not want to make DSCI as internal API - the usage is wrong, for DSCI it should be dscinitializations.dscinitialization.opendatahub.io Signed-off-by: Wen Zhou <[email protected]>
ykaliuta
approved these changes
Aug 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4d3ed37
into
opendatahub-io:incubation
8 checks passed
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Aug 15, 2024
- we do not want to make DSCI as internal API - the usage is wrong, for DSCI it should be dscinitializations.dscinitialization.opendatahub.io Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 4d3ed37)
openshift-merge-bot bot
pushed a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Aug 16, 2024
- we do not want to make DSCI as internal API - the usage is wrong, for DSCI it should be dscinitializations.dscinitialization.opendatahub.io Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 4d3ed37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria