fix(feature): preserves original target namespace #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that original target namespace is used when invoked directly in the builder. Typically subsequent calls of .TargetNamespace in the feature builder indicate coding/copy-paste error and should be reduced to one. However,in the FeatureHandler, where we group features together we do not have to specify target namespace for each feature, as it is defaulted to the one defined on the handler level. This is convenient, but limits application of features to a single namespace, as the value is always overwritten.
|
/retest |
zdtsw
approved these changes
Aug 1, 2024
| @@ -67,9 +67,11 @@ func (fb *featureBuilder) Source(source featurev1.Source) *featureBuilder { | |||
| } | |||
|
|
|||
| // TargetNamespace sets the namespace in which the feature should be applied. | |||
| // If not set, the feature will be applied in the application namespace. | |||
| // Calling it multiple times in the builder chain will have no effect, as the first value is used. | |||
There was a problem hiding this comment.
I think the original comments is still valid, but with this new one to explain the case "if it has been set"
There was a problem hiding this comment.
Not on this level, no. If not set it will fail. Implicitly setting the target namespace before building feature is done in the handler, but that's different.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a890ffa
into
opendatahub-io:incubation
8 checks passed
zdtsw
pushed a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Aug 2, 2024
This change ensures that original target namespace is used when invoked directly in the builder. Typically subsequent calls of .TargetNamespace in the feature builder indicate coding/copy-paste error and should be reduced to one. However,in the FeatureHandler, where we group features together we do not have to specify target namespace for each feature, as it is defaulted to the one defined on the handler level. This is convenient, but limits application of features to a single namespace, as the value is always overwritten.
5 tasks
zdtsw
pushed a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Aug 2, 2024
This change ensures that original target namespace is used when invoked directly in the builder. Typically subsequent calls of .TargetNamespace in the feature builder indicate coding/copy-paste error and should be reduced to one. However,in the FeatureHandler, where we group features together we do not have to specify target namespace for each feature, as it is defaulted to the one defined on the handler level. This is convenient, but limits application of features to a single namespace, as the value is always overwritten. (cherry picked from commit a890ffa)
openshift-merge-bot bot
pushed a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Aug 2, 2024
This change ensures that original target namespace is used when invoked directly in the builder. Typically subsequent calls of .TargetNamespace in the feature builder indicate coding/copy-paste error and should be reduced to one. However,in the FeatureHandler, where we group features together we do not have to specify target namespace for each feature, as it is defaulted to the one defined on the handler level. This is convenient, but limits application of features to a single namespace, as the value is always overwritten. (cherry picked from commit a890ffa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that original target namespace is used when invoked directly in the builder.
Typically subsequent calls of
.TargetNamespacein the feature builder indicate coding/copy-paste error and should be reduced to one.However,in the FeatureHandler, where we group features together we do not have to specify target namespace for each feature, as it is defaulted to the one defined on the handler level. This is convenient, but limits application of features to a single namespace, as the value is always overwritten.
How Has This Been Tested?
By running
maketests.Screenshot or short clip
Merge criteria