fix: when delete DSCI CR get stuck because the current instance updated and not preperly remove finalizer on it #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- after remove servicemesh and update condition, instance has been updated - use retryonconflict to make sure it is removed when something else might also update DSCI at the same time Signed-off-by: Wen Zhou <[email protected]>
|
Skipping CI for Draft Pull Request. |
zdtsw
requested review from
lburgazzoli and
VaishnaviHire
and removed request for
Sara4994
CFSNM
approved these changes
Jul 26, 2024
zdtsw
changed the title
lburgazzoli
approved these changes
Jul 26, 2024
CFSNM
approved these changes
Jul 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CFSNM, lburgazzoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
openshift-merge-bot
bot
merged commit fb6a37f
into
opendatahub-io:incubation
8 checks passed
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jul 29, 2024
… it (opendatahub-io#1142) - after remove servicemesh and update condition, instance has been updated - use retryonconflict to make sure it is removed when something else might also update DSCI at the same time Signed-off-by: Wen Zhou <[email protected]>
openshift-merge-bot bot
pushed a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Jul 29, 2024
… it (opendatahub-io#1142) - after remove servicemesh and update condition, instance has been updated - use retryonconflict to make sure it is removed when something else might also update DSCI at the same time Signed-off-by: Wen Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For investigation in https://issues.redhat.com/browse/RHOAIENG-10300 we can identify the problem is from an updated DSCI before removing finalizer.
To unblock this problem in regression, this is just a workaround.
and we need a proper work as suggested in https://issues.redhat.com/browse/RHOAIENG-10300
Current change:
https://issues.redhat.com/browse/RHOAIENG-9606
How Has This Been Tested?
local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.15.1-9096
test step:
also verified in QE cluster
Screenshot or short clip
Merge criteria