chore: refactor on some logic for component manifests resources #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
requested review from
ykaliuta and
VaishnaviHire
and removed request for
MarianMacik and
jackdelahunt
Signed-off-by: Wen Zhou <[email protected]>
VaishnaviHire
approved these changes
Jul 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0261670
into
opendatahub-io:incubation
8 checks passed
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
…datahub-io#1121) * chore: refactor on some logic for component manifests resources * update: move functions to other files to make deploy.so neat Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 0261670)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
…datahub-io#1121) * chore: refactor on some logic for component manifests resources * update: move functions to other files to make deploy.so neat Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 0261670)
ykaliuta
reviewed
Jul 30, 2024
| return updateResource(ctx, cli, obj, found, owner, componentName) | ||
| } | ||
| // Delete resource if it exists and component is disabled | ||
| return handleDisabledComponent(ctx, cli, found, componentName) |
There was a problem hiding this comment.
I do not support this change. It had clear logic found/not-found/error (basically, the same switch we discussed some time ago). Now it's again special case.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
can be good prepare for #1026
How Has This Been Tested?
Screenshot or short clip
Merge criteria