Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve regex to accept white spaces before delimiters(release-automation) #1102

Merged

Conversation

AjayJagan
Copy link
Contributor

@AjayJagan AjayJagan commented Jul 8, 2024

Description

Allows regex to accept whitespace before and after the delimiter '|' because when added without a whitespace github bleeds the url and makes it redirect to a malformed URL.

JIRA: https://issues.redhat.com/browse/RHOAIENG-9630

context: https://docs.google.com/document/d/1YX0zAxkl4N6-K5t4INsBqnUAxTN0GDPWV1jn9XjkgPg/edit?disco=AAABQq9SeXI

How Has This Been Tested?

The text to test is

#Release#\n\ndata-science-pipelines-operator|https:
//github.com/opendatahub-io/data-science-pipelines-operator/tree/v2.0.1 |https://github.com/opendatahub-io/data-scienc
e-pipelines-operator/releases/tag/v2.0.1

and the code to test is https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/.github/scripts/get-release-branches.js#L22-L39
with the modified regex from the pr.

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…because when added without a whitespace github bleeds the url and makes it redirect to a malformed url.
@openshift-ci openshift-ci bot requested review from ykaliuta and zdtsw July 8, 2024 14:06
@AjayJagan AjayJagan requested review from VaishnaviHire and removed request for zdtsw and ykaliuta July 8, 2024 14:06
Copy link

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sara4994

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f669c7e into opendatahub-io:incubation Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants