fix: do not redeploy segment-io's if it has been deployed previously

[zdtsw]

• dashboard is using segment-io's configmap to flip monitoring settings
• upon upgrade, Operator redploy the same configmap to set data to "true"
• pass in context

Description

https://issues.redhat.com/browse/RHOAIENG-1205

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[ykaliuta]

No, it's under if apierrs.IsNotFound(err) branch
I personally prefer to use functions for such cases, it allows to use early returns and avoid extra indentation levels, a-la

func (r *DSCInitializationReconciler) configureSegmentIO(ctx context.Context, dsciInit *dsci.DSCInitialization) error {
	// create segment.io only when configmap does not exist in the cluster
	segmentioConfigMap := &corev1.ConfigMap{}
	err := r.Client.Get(ctx, client.ObjectKey{
		Namespace: dsciInit.Spec.ApplicationsNamespace,
		Name:      "odh-segment-key-config",
	}, segmentioConfigMap)

	if err == nil {
		return nil
	}

	if !apierrs.IsNotFound(err) {
		r.Log.Error(err, "error to get configmap 'odh-segment-key-config'")
		return err
	}

	segmentPath := filepath.Join(deploy.DefaultManifestPath, "monitoring", "segment")
	if err := deploy.DeployManifestsFromPath(
		r.Client,
		dsciInit,
		segmentPath,
		dsciInit.Spec.ApplicationsNamespace,
		"segment-io",
		dsciInit.Spec.Monitoring.ManagementState == operatorv1.Managed); err != nil {
		r.Log.Error(err, "error to deploy manifests under "+segmentPath)
		return err
	}

	return nil
}


func (r *DSCInitializationReconciler) configureCommonMonitoring(ctx context.Context, dsciInit *dsci.DSCInitialization) error {
	if err := r.configureSegmentIO(ctx, dsciInit); err != nil {
		return err
	}

But it's a matter of taste

[zdtsw]

i have extract logic of segment-io into a dedicated function as you suggested.

[ykaliuta]

Small amendments required due to conflict with #1078

[zdtsw]

rebased

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ykaliuta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment