webhook: refactor with switch and helpers #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykaliuta
requested review from
zdtsw and
Sara4994
and removed request for
devguyio
|
looks good to me +1 |
zdtsw
reviewed
Jun 28, 2024
controllers/webhook/webhook.go
Outdated
| case admissionv1.Create: | ||
| resp = w.checkDupCreation(ctx, req) | ||
| default: | ||
| msg := fmt.Sprintf("Webhook skipping %v request", req.Operation) |
There was a problem hiding this comment.
i think here is meant to say "no logic check by webhook is applied on 's request" right?
There was a problem hiding this comment.
i think here is meant to say "no logic check by webhook is applied on 's request" right?
Pretty much :)
Prepare to implement deletion check. - Use switch to select supported requests, easier to add Delete then. - Remove misleading messages for the allowed case, the last one only is in use. - Use helpers to count and to compare, there will be the same logic for deletion check. - Tune allowed message. - Use go style case with several variants instead of C-style. Signed-off-by: Yauheni Kaliuta <[email protected]>
ykaliuta
force-pushed
the
webhook-refactor
branch
from
74a525b
to
f25d61c
Compare
zdtsw
approved these changes
Jun 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 97e29c9
into
opendatahub-io:incubation
8 checks passed
ykaliuta
added a commit
to ykaliuta/opendatahub-operator
that referenced
this pull request
Sep 16, 2024
Prepare to implement deletion check. - Use switch to select supported requests, easier to add Delete then. - Remove misleading messages for the allowed case, the last one only is in use. - Use helpers to count and to compare, there will be the same logic for deletion check. - Tune allowed message. - Use go style case with several variants instead of C-style. Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit 97e29c9)
ykaliuta
added a commit
to ykaliuta/opendatahub-operator
that referenced
this pull request
Sep 16, 2024
Prepare to implement deletion check. - Use switch to select supported requests, easier to add Delete then. - Remove misleading messages for the allowed case, the last one only is in use. - Use helpers to count and to compare, there will be the same logic for deletion check. - Tune allowed message. - Use go style case with several variants instead of C-style. Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit 97e29c9)
5 tasks
openshift-merge-bot bot
pushed a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Sep 18, 2024
Prepare to implement deletion check. - Use switch to select supported requests, easier to add Delete then. - Remove misleading messages for the allowed case, the last one only is in use. - Use helpers to count and to compare, there will be the same logic for deletion check. - Tune allowed message. - Use go style case with several variants instead of C-style. Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit 97e29c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare to implement deletion check.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria