fix: makes default knative secret local for serverless #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR opendatahub-io#1022 promoted knative default secret name as the default for entire platform. This can be confusing, therefore this change makes it local to kserve again.
bartoszmajsak
force-pushed
the
knative-secret
branch
from
e78802b
to
e3c9182
Compare
bartoszmajsak
commented
Jun 20, 2024
Comment on lines
-174
to
-177
| // Get default name if newSecretName is empty | ||
| if newSecretName == "" { | ||
| newSecretName = DefaultCertificateSecretName | ||
| } |
There was a problem hiding this comment.
I am not sure we need to default this to anything. I would assume the caller does due diligence.
There was a problem hiding this comment.
If line 142 is the only usage, I think it is always going to be populated...
bartoszmajsak
commented
Jun 20, 2024
| // GetDefaultIngressCertificate copies ingress cert secrets from openshift-ingress ns to given namespace. | ||
| func GetDefaultIngressCertificate(ctx context.Context, c client.Client, knativeSecret, namespace string) error { | ||
| // PropagateDefaultIngressCertificate copies ingress cert secrets from openshift-ingress ns to given namespace. | ||
| func PropagateDefaultIngressCertificate(ctx context.Context, c client.Client, secretName, namespace string) error { |
There was a problem hiding this comment.
I think this reflects the effect of this function a bit more accurately.
zdtsw
approved these changes
Jun 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 686b195
into
opendatahub-io:incubation
8 checks passed
israel-hdez
reviewed
Jun 20, 2024
zdtsw
pushed a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jun 26, 2024
…#1067) PR opendatahub-io#1022 promoted knative default secret name as the default for entire platform. This can be confusing, therefore this change makes it local to kserve again.
7 tasks
openshift-merge-bot bot
pushed a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Jun 26, 2024
…#1067) PR opendatahub-io#1022 promoted knative default secret name as the default for entire platform. This can be confusing, therefore this change makes it local to kserve again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #1022 promoted knative default secret name as the default for the entire platform as part of the
cert.gomove. This can be confusing, therefore this change makes it local to kserve again.JIRA issue:
Follow-up to #1022
ref: https://issues.redhat.com/browse/RHOAIENG-4221
How Has This Been Tested?
Screenshot or short clip:
Merge criteria: