Skip to content

Commit

Permalink
fix: wrong type (#1322)
Browse files Browse the repository at this point in the history
-  we should watch IngressController from operator.openshift.io, not the k8s ingress
-  this matched the cache we added in main

Signed-off-by: Wen Zhou <[email protected]>
  • Loading branch information
zdtsw authored Oct 31, 2024
1 parent b93dee3 commit 8ea9ea0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ func (r *DataScienceClusterReconciler) SetupWithManager(ctx context.Context, mgr
Owns(&imagev1.ImageStream{}).
Owns(&buildv1.BuildConfig{}).
Owns(&apiregistrationv1.APIService{}).
Owns(&networkingv1.Ingress{}).
Owns(&operatorv1.IngressController{}).
Owns(&admissionregistrationv1.MutatingWebhookConfiguration{}).
Owns(
&admissionregistrationv1.ValidatingWebhookConfiguration{},
Expand Down
2 changes: 1 addition & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func init() { //nolint:gochecknoinits
utilruntime.Must(admissionregistrationv1.AddToScheme(scheme))
utilruntime.Must(apiregistrationv1.AddToScheme(scheme))
utilruntime.Must(monitoringv1.AddToScheme(scheme))
utilruntime.Must(operatorv1.Install(scheme))
utilruntime.Must(operatorv1.Install(scheme)) // here also add configv1.Install(scheme) no need add configv1 explicitly
}

func initComponents(ctx context.Context, p cluster.Platform) error {
Expand Down

0 comments on commit 8ea9ea0

Please sign in to comment.