fix: ensure input CAbundle always end with a newline

- missing newline will cause problem when inject data into configmap
- this happens when user use kustomize with their own CA for DSCI, it set to use |- not |

Signed-off-by: Wen Zhou <[email protected]>

controllers/dscinitialization/suite_test.go

@@ -77,7 +77,6 @@ func TestDataScienceClusterInitialization(t *testing.T) {
 
 var testScheme = runtime.NewScheme()
 
-//nolint:fatcontext
 var _ = BeforeSuite(func() {
 	// can't use suite's context as the manager should survive the function
 	gCtx, gCancel = context.WithCancel(context.Background())

controllers/webhook/webhook_suite_test.go

@@ -79,7 +79,6 @@ func TestAPIs(t *testing.T) {
 	RunSpecs(t, "Webhook Suite")
 }
 
-//nolint:fatcontext
 var _ = BeforeSuite(func() {
 	// can't use suite's context as the manager should survive the function
 	gCtx, gCancel = context.WithCancel(context.Background())

pkg/trustedcabundle/trustedcabundle.go

@@ -5,6 +5,7 @@ import (
 	"context"
 	"fmt"
 	"strconv"
+	"strings"
 	"time"
 
 	"github.com/go-logr/logr"
@@ -47,6 +48,10 @@ func HasCABundleAnnotationDisabled(ns client.Object) bool {
 // or update existing odh-trusted-ca-bundle configmap if already exists with new content of .data.odh-ca-bundle.crt
 // this is certificates for the cluster trusted CA Cert Bundle.
 func CreateOdhTrustedCABundleConfigMap(ctx context.Context, cli client.Client, namespace string, customCAData string) error {
+	// Adding newline breaker if user input does not have it
+	if !strings.HasSuffix(customCAData, "\n") {
+		customCAData += "\n"
+	}
 	// Expected configmap for the given namespace
 	desiredConfigMap := &corev1.ConfigMap{
 		TypeMeta: metav1.TypeMeta{