Update ENVTEST_K8S_VERSION for s390x

[satyamg1620]

Updated the ENVTEST_K8S_VERSION for s390x support

How Has This Been Tested?

• In Makefile, change ENVTEST_K8S_VERSION to 1.29
• Run make -e IMG=quay.io/${USER}/odh-model-controller:latest container-build container-push
• The container-build will internally run the make test command to pass all the unit tests and build image after passing tests

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

Hi @satyamg1620. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[satyamg1620]

@israel-hdez , @terrytangyuan , the workflow does contain part for triggering image, Can you please manually trigger to create image for s390x

[israel-hdez]

/ok-to-test

[israel-hdez]

the workflow does contain part for triggering image, Can you please manually trigger to create image for s390x

Which workflow you mean?

[satyamg1620]

Sorry, my mistake. There is no workflow for triggering image. So Can @israel-hdez , @terrytangyuan please trigger it manually to create the image for s390x or should I create the github workflow for that?

[satyamg1620]

@israel-hdez @terrytangyuan Can you please merge the PR?

[satyamg1620]

@israel-hdez @terrytangyuan Can you please merge the PR?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: satyamg1620, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spolti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[satyamg1620]

@israel-hdez @terrytangyuan Can you please merge the PR?

[israel-hdez]

@satyamg1620 Sorry for the delay. Merging...

Sorry, my mistake. There is no workflow for triggering image.
Can please trigger it manually to create the image for s390x or should I create the github workflow for that?

Do you mean that you would like images published for s390x?
Or you just need to be sure that they would build?

The ci/prow/images job is building images as check (not publishing them), but that's only for amd64.

/lgtm

[modassarrana89]

@satyamg1620 Sorry for the delay. Merging...

Sorry, my mistake. There is no workflow for triggering image.
Can please trigger it manually to create the image for s390x or should I create the github workflow for that?

Do you mean that you would like images published for s390x? Or you just need to be sure that they would build?

The ci/prow/images job is building images as check (not publishing them), but that's only for amd64.

/lgtm

@israel-hdez Can we add in CI/prow/images job for multi-arch i.e. s390x & ppc64le. if it is possible , do share with us , as we don't have access to it

[israel-hdez]

@israel-hdez Can we add in CI/prow/images job for multi-arch i.e. s390x & ppc64le. if it is possible , do share with us , as we don't have access to it.

Sorry to ask again, as I don't clearly understand:

Do you want multi-arch images published? or do you want a CI check that multi-arch images would build correctly?

[modassarrana89]

@israel-hdez Can we add in CI/prow/images job for multi-arch i.e. s390x & ppc64le. if it is possible , do share with us , as we don't have access to it.

Sorry to ask again, as I don't clearly understand:

Do you want multi-arch images published? or do you want a CI check that multi-arch images would build correctly?

@israel-hdez Multi-arch image should be build & published. Since i don't have access to add option to build & publish multi-arch image , so thats why i asked is there a way i can update CI/prow/images job for it .