[RHOAIENG-7484] - make container builder configurable for odh-control… #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israel-hdez
reviewed
May 22, 2024
Makefile
Outdated
| # Default for docker, no value | ||
| ARCH_PARAMETER = | ||
| ifeq ($(ENGINE),podman) | ||
| ARCH_PARAMETER = --arch $(ARCH) |
There was a problem hiding this comment.
Would --platform work? Such arg seems to be supported both by docker and podman, so we no longer would need conditionals.
There was a problem hiding this comment.
work if you enforce os to linux as well.
--arch does it automatically.
--platform
Error: creating build container: choosing an image from manifest list docker://registry.access.redhat.com/ubi8/go-toolset:1.19: no image found in manifest list for architecture amd64, variant "", OS darwin
…ler operator chore: Allow to set the engine for the make container build and push goals Signed-off-by: Spolti <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ler operator
chore: Allow to set the engine for the make container build and push goals
Description
How Has This Been Tested?
Merge criteria: