adjustments to probes

Signed-off-by: heyselbi <[email protected]>
opendatahub-io · May 29, 2024 · e5753e9 · e5753e9
1 parent 87a6b8c
commit e5753e9
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 16 deletions.
diff --git a/config/runtimes/caikit-tgis-template.yaml b/config/runtimes/caikit-tgis-template.yaml
@@ -63,16 +63,19 @@ objects:
                 - -m
                 - caikit_health_probe
                 - readiness
-            initialDelaySeconds: ${{PROBES_INITIAL_DELAY_SECONDS}}
+            initialDelaySeconds: 5
           livenessProbe:
             exec:
               command:
                 - python
                 - -m
                 - caikit_health_probe
                 - liveness
-            initialDelaySeconds: ${{PROBES_INITIAL_DELAY_SECONDS}}
-parameters:
-  - name: PROBES_INITIAL_DELAY_SECONDS
-    description: Amount of time to wait before probing the container for readiness
-    value: "5"
+            initialDelaySeconds: 5
+          startupProbe:
+            httpGet:
+              port: 8080
+              path: /health
+            # Allow 12 mins to start
+            failureThreshold: 24
+            periodSeconds: 30
diff --git a/config/runtimes/tgis-template.yaml b/config/runtimes/tgis-template.yaml
@@ -48,18 +48,21 @@ objects:
               command:
                 - curl
                 - localhost:3000/health
-            initialDelaySeconds: ${{PROBES_INITIAL_DELAY_SECONDS}}
+            initialDelaySeconds: 5
           livenessProbe:
             exec:
               command:
                 - curl
                 - localhost:3000/health
-            initialDelaySeconds: ${{PROBES_INITIAL_DELAY_SECONDS}}
+            initialDelaySeconds: 5
+          startupProbe:
+            httpGet:
+              port: 8080
+              path: /health
+            # Allow 12 mins to start
+            failureThreshold: 24
+            periodSeconds: 30
           ports:
             - containerPort: 8033
               name: h2c
               protocol: TCP
-parameters:
-  - name: PROBES_INITIAL_DELAY_SECONDS
-    description: Amount of time to wait before probing the container for readiness
-    value: "5"
diff --git a/config/runtimes/vllm-template.yaml b/config/runtimes/vllm-template.yaml
@@ -46,14 +46,12 @@ objects:
             httpGet: 
               port: 8080
               path: /health
-            periodSeconds: 30
-            timeoutSeconds: 5
+            initialDelaySeconds: 5
           livenessProbe:
             httpGet: 
               port: 8080
               path: /health
-            periodSeconds: 100
-            timeoutSeconds: 8
+            initialDelaySeconds: 5
           startupProbe:
             httpGet:
               port: 8080