Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Upgrade notebook-controller to v1.7.0-2 of odh/kubeflow #900

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Aug 1, 2023

Upgrade notebook-controller to v1.7.0-2 of odh/kubeflow

Description

The tag v1.7.0-2 of odh/kubeflow contains fixes.
Details available on release notes:
https://github.com/opendatahub-io/kubeflow/releases/tag/v1.7.0-2

Fixes: opendatahub-io/odh-dashboard#1619

How Has This Been Tested?

Deploy on an ODH cluster.
And execute a notebook to test this behaviour.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89
Copy link
Member

atheo89 commented Aug 1, 2023

/lgtm

@harshad16
Copy link
Member Author

/retest-required

@harshad16 harshad16 changed the title [WIP] Upgrade notebook-controller to v1.7.0-2 of odh/kubeflow Upgrade notebook-controller to v1.7.0-2 of odh/kubeflow Aug 1, 2023
@harshad16
Copy link
Member Author

Ready for Review and Merge.

@harshad16
Copy link
Member Author

/retest-required

1 similar comment
@harshad16
Copy link
Member Author

/retest-required

Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@harshad16
Copy link
Member Author

/retest-required

1 similar comment
@atheo89
Copy link
Member

atheo89 commented Aug 4, 2023

/retest-required

@harshad16
Copy link
Member Author

The e2e tests are failing, as the odh-dashboard part of e2e, uses ods-ci for verifying the notebook workflow.
The ods-ci spins a notebook and goes over each login page to test the notebook out.
it is failing, as the notebook is updated with this tag v1.7.0-2 to have no more skip of oauth-proxy login page.
so traversing through the oauth-proxy login page needs to be included in ods-ci.
i will work on getting that bit in.

For this current PR.
@LaVLaS would you be inclined to get this merged and i can work on getting the ci issue resolved via another pr.
or would you suggest to get the ci fixed first.

the reason to get this merged, is as the notebook-controller previous version v1.7.0-1 would cause issue with odh-dashboard latest master

@LaVLaS
Copy link
Contributor

LaVLaS commented Aug 4, 2023

@harshad16 We will need to resolve this test failure in this PR since their appears to be an issue around the test that verifies the functionality between dashboard and notebook-controller

Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS, VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LaVLaS,VaishnaviHire]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1f40471 into opendatahub-io:master Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: unable to start notebook server due to duplicate values in StatefulSet
5 participants