Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update TrustyAI manifests to allow parameterized images #895

Merged

Conversation

RobGeada
Copy link
Contributor

@RobGeada RobGeada commented Jul 24, 2023

  • Allows for the specification of TrustyAI-service images via an optional parameter in the trustyai-service kfdef, if desired. If no image values are passed, the default quay.io/trustyai/trustyai-service:latest is used.

Description

This is now possible:

  - kustomizeConfig:
      repoRef:
        name: manifests
        path: trustyai-service-operator
      parameters:
         - name: trustyaiServiceImageName
           value: NEW_IMAGE_NAME
        - name: trustyaiServiceImageTag
          value: NEW_IMAGE_TAG
    name: trustyai-service-operator

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruivieira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e55c01b into opendatahub-io:master Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants