Add new imagestreams to inlude Code-Server and R-Studio

[atheo89]

This PR introduces the Code-Server (VS-Code) and R-Studio workbench images into OOTB.

Related issue: https://github.com/opendatahub-io/odh-manifests/issues/843

Description

How Has This Been Tested?

• Deploy ODH with the additional overlay enabled for notebook-images

  - kustomizeConfig:
      overlays:
      - additional
      repoRef:
        name: manifests
        path: notebook-images
    name: notebook-images

• Login to odh-dashboard and spawn a notebook Code Server, R Studio or Cuda R Studio
• Confirm that the notebook spawned successfully and its functionality works

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[atheo89]

/hold

[atheo89]

/unhold
It's ready for review @LaVLaS @VaishnaviHire

[LaVLaS]

@harshad16 @atheo89 The main question is is we want to support these notebooks Core deployment. Can you move the new notebooks to an optional notebook overlay so that they are "opt-in" for the user

[atheo89]

@LaVLaS Sure! Is it fine if we move them to the overlays/additional directory?

[harshad16]

@LaVLaS can you guide us a little here,
we want to provide them with Tier 1 in ODH, should these be in the base layer itself, along with other OOTB images.
isn't place them in overlays makes them same as the opendatahub-io-contrib?

[LaVLaS]

@LaVLaS can you guide us a little here, we want to provide them with Tier 1 in ODH, should these be in the base layer itself, along with other OOTB images. isn't place them in overlays makes them same as the opendatahub-io-contrib?

@harshad16 These notebooks would be included the same additional overlay as the Elyra notebook.

[atheo89]

@LaVLaS @harshad16 PTAL

[atheo89]

/retest-required

[harshad16]

/lgtm
/approve

thanks 💯

[LaVLaS]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• notebook-images/OWNERS [LaVLaS]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shalberd]

@LaVLaS Elyra should not really be in additional anymore in that form ... it's part of all base images now.
Cool to see Guillome's R Studio from contrib in additional now

[harshad16]

Elyra should not really be in additional anymore in that form ... it's part of all base images now. Cool to see Guillome's R Studio from contrib in additional now

It would be removed in the next release cycle.