Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update deploy-python-model-quickstart.yaml #835

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Update deploy-python-model-quickstart.yaml #835

merged 3 commits into from
Jun 15, 2023

Conversation

jjasghar
Copy link
Contributor

Description

  • Updated to the "prediction_s_" not "prediction" per the flask app.
  • Fixed the formating with "<" not being able to be read via the tutorial software.

How Has This Been Tested?

Verified in my test env.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented May 31, 2023

Hi @jjasghar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Member

@kywalker-rh Not sure who reviews our Quick Starts -- but there is a slight change to the python one needing a content review.

@kywalker-rh
Copy link

@andrewballantyne I'm not sure either. Maybe Audrey?

@andrewballantyne
Copy link
Member

/ok-to-test

@zdtsw
Copy link
Member

zdtsw commented Jun 7, 2023

should

This task is not verified yet. Make sure your application built correctly. Make sure you remembered to add `/prediction` to the end of the application URL to get to the endpoint.
be updated too?

@jjasghar
Copy link
Contributor Author

jjasghar commented Jun 7, 2023

I don't think the failures are due to my changes. They seem e2e?

@andrewballantyne
Copy link
Member

/retest

Yeah, they gotta be a flake... you're changing yaml content. Let us retest and see.

@andrewballantyne
Copy link
Member

/retest

@andrewballantyne
Copy link
Member

@LaVLaS @VaishnaviHire is our tests really that flaky? I'm not sure how this PR could break a test, as it's just quickstart content.

@andrewballantyne
Copy link
Member

/retest

@LaVLaS
Copy link
Contributor

LaVLaS commented Jun 14, 2023

@LaVLaS @VaishnaviHire is our tests really that flaky? I'm not sure how this PR could break a test, as it's just quickstart content.

Check the logs to see that the dashboard test is failing because the Jupyter tile is not visible when it attempts to spawn a notebook. See Screenshots from the test run. Without debugging the CI environment while it is running this PR should rebase on top of the latest dashboard version

jjasghar and others added 3 commits June 14, 2023 15:12
- Updated to the "prediction_s_" not "prediction" per the flask app.
- Fixed the formating with "<" not being able to be read via the tutorial software.
@andrewballantyne
Copy link
Member

Okay sweet... we got a success.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Member

Awesome, thanks for your PR @jjasghar -- we got through the CI troubles 😄 this should merge automatically when the bot finishes up.

@openshift-merge-robot openshift-merge-robot merged commit be72528 into opendatahub-io:master Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants