-
Notifications
You must be signed in to change notification settings - Fork 211
Update deploy-python-model-quickstart.yaml #835
Update deploy-python-model-quickstart.yaml #835
Conversation
Hi @jjasghar. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kywalker-rh Not sure who reviews our Quick Starts -- but there is a slight change to the python one needing a content review. |
@andrewballantyne I'm not sure either. Maybe Audrey? |
/ok-to-test |
should
|
I don't think the failures are due to my changes. They seem e2e? |
/retest Yeah, they gotta be a flake... you're changing yaml content. Let us retest and see. |
/retest |
@LaVLaS @VaishnaviHire is our tests really that flaky? I'm not sure how this PR could break a test, as it's just quickstart content. |
/retest |
Check the logs to see that the dashboard test is failing because the Jupyter tile is not visible when it attempts to spawn a notebook. See Screenshots from the test run. Without debugging the CI environment while it is running this PR should rebase on top of the latest dashboard version |
- Updated to the "prediction_s_" not "prediction" per the flask app. - Fixed the formating with "<" not being able to be read via the tutorial software.
Co-authored-by: Deepak Chourasia <[email protected]>
Co-authored-by: Deepak Chourasia <[email protected]>
Okay sweet... we got a success. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Awesome, thanks for your PR @jjasghar -- we got through the CI troubles 😄 this should merge automatically when the bot finishes up. |
Description
How Has This Been Tested?
Verified in my test env.
Merge criteria: