Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Include kfp-tekton package in notebook annotation #812

Merged
merged 1 commit into from
May 15, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented May 11, 2023

Include kfp-tekton package in notebook annotation

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks 👍

@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member Author

atheo89 commented May 12, 2023

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented May 12, 2023

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/411-odh-manifests-e2e b435e24 link true /test 411-odh-manifests-e2e
ci/prow/odh-manifests-e2e b435e24 link true /test odh-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LaVLaS
Copy link
Contributor

LaVLaS commented May 15, 2023

Manual merge of this issue since the metadata data changes have been approved and they don't break or change existing functionality. The CI tests for the notebooks are working as intended and the lone CI failure is related to a failure affecting all PRs

@LaVLaS LaVLaS merged commit cd84b3a into opendatahub-io:master May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants