-
Notifications
You must be signed in to change notification settings - Fork 211
Conversation
Hi @strangiato. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
70d2ad8
to
801a8de
Compare
/ok-to-test |
README.md
Outdated
|
||
| Manifest Version | Operator Version | ODH Dashboard | ODH Notebook Controller | ODH Notebook Images | Data Science Pipelines | ModelMesh | | ||
| ---------------- | ---------------- | ------------- | ----------------------- | ------------------- |----------------------- | --------- | | ||
| v1.4.1 | v1.4.1 | v2.5.2 | ??? | v1.3.1 | v1.2.1 | v0.9.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! It's good to see what version everything is at. Is the Manifest Version really different than the Operator Version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notebook-controller version is v1.6 since the current notebook-controller image is built off of the v1.6 release branch
@strangiato I don't think we need to include the versions for odh-manifests and odh-operator since
- They will be the same number
- We should be keeping the component versions up to date so anyone pulling the manifests from the default branch know what versions are included.
I think we can push document the compatibility matrix for ODH Version --> Component version in the GitHub and opendatahub-io release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some updates based on the feedback.
I dropped the Operator Version. I originally included it because I know there were some manifest releases in the past that did not include a separate operator version. Sounds like that won't be the case moving forward thought.
Updated the notebook controller version for both 1.4.1 and 1.4.0. It didn't appear that anything changed between the the so I assume 1.4.0 was also running 1.6.
I also updated the notebook images for 1.4.0 to be N/A. It looks like with 1.4.1 the goal was to introduce the pre-built images, so I assume it probably doesn't make sense to include a version number for this in 1.4.0.
Let me know if there are any other changes you think would be relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@strangiato I don't know if we need Manifest Version
in the table since the compatibility matrix would be incorrect between releases of odh-manifests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LaVLaS Would you prefer to update that column to Operator Version
instead? I'm not quite sure what you mean by "the compatibility matrix would be incorrect between releases of odh-manifests."
Would you want to add a row formaster
as well to document what the master branch is currently at?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@strangiato Apologies. I just realized that the table is trying to list the component versions for every released version of ODH (1.4.0, 1.4.1, ..., 1.4.z, 1.5.z, ...). I was thinking it just showed the current component versions in the master
branch.
I'll defer to community opinion if we need a table to show older versions in the README if they are available as part of the release notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no problem -- but maybe we mark the current latest as "master" version and just copy it down a line in the table and rename that "master" version to whatever we release for the Operator.
bcbacb0
to
41818b3
Compare
41818b3
to
c8b83e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I like the top line being the current running version
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@strangiato: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Sounds like the Dashboard tests are failing -- guess they are flaky. 🤞 Retest away! |
This is just a README update so we don't need to rely on a successful CI test ru |
Description
Closes #687
Add a table to track versions of the different ODH components.
Version numbers were pulled from opendatahub.io release notes blogs:
https://opendatahub.io/news/2023-01-24/odh-release-1.4.1-blog.html
https://opendatahub.io/news/2022-10-31/odh-release-1.4.0-blog.html
Pipelines version numbers regressed in the notes so most likely one of the pipelines version numbers is wrong.
Also, unsure what version of the notebook controller is being used in each release.
I'm happy to update the version numbers before this is merged if someone can provide feedback on what the version numbers should be set to.
How Has This Been Tested?
Docs only
Merge criteria: