Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add versions table #723

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Add versions table #723

merged 2 commits into from
Feb 10, 2023

Conversation

strangiato
Copy link
Contributor

Description

Closes #687

Add a table to track versions of the different ODH components.

Version numbers were pulled from opendatahub.io release notes blogs:

https://opendatahub.io/news/2023-01-24/odh-release-1.4.1-blog.html
https://opendatahub.io/news/2022-10-31/odh-release-1.4.0-blog.html

Pipelines version numbers regressed in the notes so most likely one of the pipelines version numbers is wrong.

Also, unsure what version of the notebook controller is being used in each release.

I'm happy to update the version numbers before this is merged if someone can provide feedback on what the version numbers should be set to.

How Has This Been Tested?

Docs only

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • [N/A] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [N/A] The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2023

Hi @strangiato. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anishasthana
Copy link
Member

/ok-to-test

README.md Outdated

| Manifest Version | Operator Version | ODH Dashboard | ODH Notebook Controller | ODH Notebook Images | Data Science Pipelines | ModelMesh |
| ---------------- | ---------------- | ------------- | ----------------------- | ------------------- |----------------------- | --------- |
| v1.4.1 | v1.4.1 | v2.5.2 | ??? | v1.3.1 | v1.2.1 | v0.9.0 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! It's good to see what version everything is at. Is the Manifest Version really different than the Operator Version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebook-controller version is v1.6 since the current notebook-controller image is built off of the v1.6 release branch

@strangiato I don't think we need to include the versions for odh-manifests and odh-operator since

  1. They will be the same number
  2. We should be keeping the component versions up to date so anyone pulling the manifests from the default branch know what versions are included.

I think we can push document the compatibility matrix for ODH Version --> Component version in the GitHub and opendatahub-io release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some updates based on the feedback.

I dropped the Operator Version. I originally included it because I know there were some manifest releases in the past that did not include a separate operator version. Sounds like that won't be the case moving forward thought.

Updated the notebook controller version for both 1.4.1 and 1.4.0. It didn't appear that anything changed between the the so I assume 1.4.0 was also running 1.6.

I also updated the notebook images for 1.4.0 to be N/A. It looks like with 1.4.1 the goal was to introduce the pre-built images, so I assume it probably doesn't make sense to include a version number for this in 1.4.0.

Let me know if there are any other changes you think would be relevant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strangiato I don't know if we need Manifest Version in the table since the compatibility matrix would be incorrect between releases of odh-manifests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LaVLaS Would you prefer to update that column to Operator Version instead? I'm not quite sure what you mean by "the compatibility matrix would be incorrect between releases of odh-manifests."

Would you want to add a row formaster as well to document what the master branch is currently at?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strangiato Apologies. I just realized that the table is trying to list the component versions for every released version of ODH (1.4.0, 1.4.1, ..., 1.4.z, 1.5.z, ...). I was thinking it just showed the current component versions in the master branch.

I'll defer to community opinion if we need a table to show older versions in the README if they are available as part of the release notes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem -- but maybe we mark the current latest as "master" version and just copy it down a line in the table and rename that "master" version to whatever we release for the Operator.

@strangiato strangiato force-pushed the versions-table branch 2 times, most recently from bcbacb0 to 41818b3 Compare February 6, 2023 16:57
@openshift-ci openshift-ci bot removed the lgtm label Feb 8, 2023
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like the top line being the current running version

@openshift-ci openshift-ci bot added the lgtm label Feb 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewballantyne
Once this PR has been reviewed and has the lgtm label, please assign anishasthana for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 9, 2023

@strangiato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odh-manifests-e2e ccf97a6 link true /test odh-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andrewballantyne
Copy link
Member

/retest

Sounds like the Dashboard tests are failing -- guess they are flaky. 🤞 Retest away!

@LaVLaS
Copy link
Contributor

LaVLaS commented Feb 10, 2023

This is just a README update so we don't need to rely on a successful CI test ru

@LaVLaS LaVLaS merged commit 82e885b into opendatahub-io:master Feb 10, 2023
@strangiato strangiato deleted the versions-table branch April 4, 2023 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation on components status and tier in each version of ODH
4 participants