Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add "additional" notebook images overlay #721

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

LaVLaS
Copy link
Contributor

@LaVLaS LaVLaS commented Jan 23, 2023

Add Elyra notebook as part of the new additional notebooks

Signed-off-by: Landon LaSmith [email protected]

Description

Adds new Elyra notebook as an additonal overlay for notebook-images

How Has This Been Tested?

Successfully deployed and spawned this notebook using

Merge criteria:

  1. Deploy ODH with the additional overlay enabled for notebook-images
  2. Login to odh-dashboard and spawn an Elyra notebook
  3. Confirm that the notebook spawned successfully and Elyra functionality works

Add Elyra notebook as part of the new additional notebooks

Signed-off-by: Landon LaSmith <[email protected]>
@VaishnaviHire
Copy link
Member

Worked well with ocp 4.11

/lgtm

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Jan 23, 2023

@atheo89 @VaishnaviHire Feel free to recommend a different layout for the additional overlay. I wanted to provide some separation between odh-core notebooks and fully supported (but not core) notebooks in our org

@atheo89
Copy link
Member

atheo89 commented Jan 24, 2023

@LaVLaS I totally agree with you on the separation of the notebooks, the additional looks good to me.

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Feb 6, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit bd53375 into opendatahub-io:master Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants