Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add S3 Override Env Vars for DSP API Server #691

Conversation

gmfrasca
Copy link
Member

@gmfrasca gmfrasca commented Nov 1, 2022

Description

Adds additional environment variables that allows user to override the Data Science Pipeline Object Store server

How Has This Been Tested?

Testing Steps:

  1. Deploy DSP on ODH without the default_configs overlay.
  2. kustomize build the default_configs overlay, and update any s3 metadata in mlpipeline-minio-artifact and ds-pipeline-config to point to an external s3 server, the oc apply -f the files (there should be 4 total files updated)*
  3. Got to the DSP UI and run a pipeline
  4. Verify artifacts are stored on your external s3 server

*alternatively you can download this template file, then run oc process -f $template_file [-p param1=param ...] | oc apply -f - with your desired parameters

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@rimolive
Copy link
Contributor

rimolive commented Nov 2, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 2, 2022
@LaVLaS LaVLaS self-requested a review November 3, 2022 13:26
@LaVLaS
Copy link
Contributor

LaVLaS commented Nov 3, 2022

@gmfrasca @rimolive The README needs an update for the current overlays and should include an update for this new feature. Can you update it in this PR or a separate PR to make sure the info is current?

@gmfrasca
Copy link
Member Author

gmfrasca commented Nov 3, 2022

@LaVLaS - let's handle that in a separate PR/Issue to keep the changesets relevant to their respective updates

Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

README update is included in #694

@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit 1af4f1d into opendatahub-io:master Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants