This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Jupyterhub Idle Culler update #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maroroman Can you add a quick note to the JupyterHub README about enabling this overlay and how it's configured? |
LaVLaS
reviewed
Jun 4, 2022
maroroman
force-pushed
the
culler-update
branch
2 times, most recently
from
a052f12
to
df97a52
Compare
LaVLaS
approved these changes
Jul 11, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LaVLaS, maroroman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dol
reviewed
Nov 18, 2022
| @@ -11,6 +11,23 @@ spec: | |||
| labels: | |||
| app: jupyterhub-idle-culler | |||
| spec: | |||
| initContainers: | |||
| - name: check-for-jh | |||
| image: 'quay.io/odh-jupyterhub/jupyterhub-img:v0.3.3' | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks updates from downstream, as well as adds a value to the jupyterhub-cfg
Additionally it adds the content of PR red-hat-data-services#220 which adds limits and requests to the culler container.
This PR should also allow the dashboard to work with the culler, although the value change will not be applied unless the operator is scaled down.