[WIP] Update 'Resource name' fields to meet UX guidelines: Cluster storage

[jeff-phillips-18]

WIP

Depends on

• Update 'Resource name' fields to meet UX guidelines: Serving Runtimes #3443
• [WIP] Update 'Resource name' fields to meet UX guidelines: Model registries and Inference services #3464

Closes RHOAIENG-14746

Description

Updates create/edit cluster storage modals to use K8sNameDescriptionField component in order to meet current UX guidelines.

Screen shots

Create cluster storage

Create cluster storage - edit resource name

Edit cluster storage

How Has This Been Tested?

• Navigate to a project and go to the Cluster storage tab

  • Select Add cluster storage
  • Enter a name
  • Verify the Add storage button is enabled
  • View the resource name via the Edit resource name link.
  • Change the resource name to something invalid (ie. contains a space)
  • Verify the Add storage button is disabled
  • Change the resource name to something valid
  • Enter a description
  • Verify the Add storage button is enabled
  • Save the storage.
  • Verify the cluster storage is created with the correct Display name and Resource Name and Description.

• Navigate to a project and go to the Cluster storage tab

  • Select a kebab for an existing cluster storage item
  • Select Edit storage
  • Verify the name, resource name, and description are shown correctly
  • Verify the resource name is not editable

• Navigate to a project and go to the Workbenches tab

  • Select Create workbench
  • Enter a name
  • Select an Image
  • Verify the Create workbench button is enabled
  • Click the Create storage button
    • Enter a name
    • Enter a valid mount path
    • Verify the Create button is enabled
    • View the resource name via the Edit resource name link.
    • Change the resource name to something invalid (ie. contains a space)
    • Verify the Create button is disabled
    • Change the resource name to something valid
    • Enter a description
    • Verify the Create button is enabled
    • Save the storage.
  • In the Cluster storage list, select the kebab next to the new storage to be created
    • Verify the cluster storage is created with the correct Display name and Resource Name and Description.

Test Impact

Updated unit tests for new fields

Request review criteria:

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

/cc @simrandhaliw

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 94.82759% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.39%. Comparing base (24024ae) to head (a1e9fb8).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...screens/projects/kServeModal/ManageKServeModal.tsx	92.85%	3 Missing ⚠️
...erenceServiceModal/ManageInferenceServiceModal.tsx	92.00%	2 Missing ⚠️
...creens/spawner/storage/CreateNewStorageSection.tsx	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3483      +/-   ##
==========================================
+ Coverage   85.38%   85.39%   +0.01%     
==========================================
  Files        1352     1350       -2     
  Lines       30860    30866       +6     
  Branches     8612     8618       +6     
==========================================
+ Hits        26349    26358       +9     
+ Misses       4511     4508       -3     

Files with missing lines	Coverage Δ
...8sNameDescriptionField/K8sNameDescriptionField.tsx	100.00% <100.00%> (ø)
.../ServingRuntimeModal/ManageServingRuntimeModal.tsx	93.75% <100.00%> (+0.59%)	⬆️
...d/src/pages/modelServing/screens/projects/utils.ts	94.30% <ø> (-0.03%)	⬇️
frontend/src/pages/modelServing/screens/types.ts	100.00% <ø> (ø)
...ojects/screens/detail/storage/BaseStorageModal.tsx	80.95% <100.00%> (-1.66%)	⬇️
...rc/pages/projects/screens/spawner/storage/utils.ts	69.23% <100.00%> (+1.23%)	⬆️
frontend/src/pages/projects/types.ts	100.00% <ø> (ø)
frontend/src/utilities/useGenericObjectState.ts	100.00% <100.00%> (ø)
...creens/spawner/storage/CreateNewStorageSection.tsx	96.29% <90.90%> (-3.71%)	⬇️
...erenceServiceModal/ManageInferenceServiceModal.tsx	93.67% <92.00%> (-0.08%)	⬇️
... and 1 more

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24024ae...a1e9fb8. Read the comment docs.