Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump DSPA version from v1alpha to v1 #3475

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Nov 14, 2024

https://issues.redhat.com/browse/RHOAIENG-15234

Description

Reopening this PR
DataSciencePipelineApplicationModels to be bumped to v1

How Has This Been Tested?

  • Adjust the pipeline devFlags to point to main
  • check whether pipeline server created successfully

Test Impact

  • Updated the mocks to use v1

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.57%. Comparing base (96e06a2) to head (48ada61).
Report is 124 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3475      +/-   ##
==========================================
+ Coverage   85.01%   85.57%   +0.56%     
==========================================
  Files        1327     1349      +22     
  Lines       29770    30745     +975     
  Branches     8149     8577     +428     
==========================================
+ Hits        25308    26311    +1003     
+ Misses       4462     4434      -28     
Files with missing lines Coverage Δ
frontend/src/api/models/pipelines.ts 100.00% <ø> (ø)

... and 245 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e06a2...48ada61. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, DSP has v1 released already in 2.16 so this should be safe to merge
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7ceb459 into opendatahub-io:main Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants