Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed workloads popover fix #3472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Nov 13, 2024

Closes: RHOAIENG-12280

Description

Changes the tooltip for requested resources to a popover

How Has This Been Tested?

Tested locally using Cypress
Navigate to Distributed workload metrics, and click the icon next to Requested resources

Test Impact

No new tests added

Screenshots

Before:
Screenshot 2024-11-12 at 2 06 34 PM

After:
Screenshot 2024-11-14 at 9 01 30 AM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from pnaik1 and ppadti November 13, 2024 16:05
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashley-o0o
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Nov 13, 2024
@ashley-o0o
Copy link
Contributor Author

In reference to the conversation started in the ticket. Is this title suitable for the popover? @simrandhaliw @kaedward

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.59%. Comparing base (4066b69) to head (743c2e5).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...cs/GlobalDistributedWorkloadsProjectMetricsTab.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3472      +/-   ##
==========================================
- Coverage   85.64%   85.59%   -0.05%     
==========================================
  Files        1347     1349       +2     
  Lines       30676    30748      +72     
  Branches     8554     8578      +24     
==========================================
+ Hits        26271    26318      +47     
- Misses       4405     4430      +25     
Files with missing lines Coverage Δ
...s/global/projectMetrics/sections/DWSectionCard.tsx 100.00% <100.00%> (ø)
...cs/GlobalDistributedWorkloadsProjectMetricsTab.tsx 75.00% <50.00%> (-25.00%) ⬇️

... and 41 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4066b69...743c2e5. Read the comment docs.

@simrandhaliw
Copy link

@ashley-o0o UX has decided not to include a title in this popover. It will remain a basic popover with padding and close button, but without a heading. E.g.
Popover without header and footer  Maintain padding

@ashley-o0o ashley-o0o force-pushed the 12280/distributed-workloads-popover branch from 118393c to 743c2e5 Compare November 14, 2024 14:02
@ashley-o0o
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants