-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed workloads popover fix #3472
base: main
Are you sure you want to change the base?
Distributed workloads popover fix #3472
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
In reference to the conversation started in the ticket. Is this title suitable for the popover? @simrandhaliw @kaedward |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3472 +/- ##
==========================================
- Coverage 85.64% 85.59% -0.05%
==========================================
Files 1347 1349 +2
Lines 30676 30748 +72
Branches 8554 8578 +24
==========================================
+ Hits 26271 26318 +47
- Misses 4405 4430 +25
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@ashley-o0o UX has decided not to include a title in this popover. It will remain a basic popover with padding and close button, but without a heading. E.g. |
118393c
to
743c2e5
Compare
/unhold |
Closes: RHOAIENG-12280
Description
Changes the tooltip for requested resources to a popover
How Has This Been Tested?
Tested locally using Cypress
Navigate to Distributed workload metrics, and click the icon next to Requested resources
Test Impact
No new tests added
Screenshots
Before:
After:
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main