-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution reference on the artifact view what execution produced the artifacts #3470
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3470 +/- ##
==========================================
- Coverage 85.65% 85.58% -0.07%
==========================================
Files 1347 1350 +3
Lines 30676 30764 +88
Branches 8554 8584 +30
==========================================
+ Hits 26275 26329 +54
- Misses 4401 4435 +34
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
91f777a
to
6ed9229
Compare
6ed9229
to
6147624
Compare
@pnaik1 this looks good. however i think we should also add the reference to the pipeline run in the list of references if possible. PMs request was looking to get back to run directly from the artifact
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functionality looks good otherwise
@Gkrumbach07
the artifact details page should look something like this???
or just original/root runs
|
https://issues.redhat.com/browse/RHOAIENG-14415
Description
added the execution reference in the artifact detail page that it came from and if it was cached then show the root execution
How Has This Been Tested?
Test Impact
Added cypress test cases
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
cc @yannnz