Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution reference on the artifact view what execution produced the artifacts #3470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Nov 13, 2024

https://issues.redhat.com/browse/RHOAIENG-14415

Description

added the execution reference in the artifact detail page that it came from and if it was cached then show the root execution

Screenshot 2024-11-13 at 5 44 54 PM

How Has This Been Tested?

  1. Run a pipeline which contains artifacts
  2. Go to Artifact Page-> click on the artifactName
  3. check if the Reference section is present
  4. Check if the execution link redirects to execution page
  5. Check execution link is a root execution link if its cached

Test Impact

Added cypress test cases

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main
    cc @yannnz

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pnaik1 pnaik1 changed the title Determine on the artifact view what execution produced the artifacts Execution reference on the artifact view what execution produced the artifacts Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.58%. Comparing base (6f439e5) to head (6147624).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...pipelines/apiHooks/mlmd/useGetEventByArtifactId.ts 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3470      +/-   ##
==========================================
- Coverage   85.65%   85.58%   -0.07%     
==========================================
  Files        1347     1350       +3     
  Lines       30676    30764      +88     
  Branches     8554     8584      +30     
==========================================
+ Hits        26275    26329      +54     
- Misses       4401     4435      +34     
Files with missing lines Coverage Δ
...ifacts/ArtifactDetails/ArtifactOverviewDetails.tsx 95.00% <100.00%> (+3.33%) ⬆️
...tions/details/ExecutionDetailsReferenceSection.tsx 70.58% <100.00%> (-1.64%) ⬇️
...s/pipelines/global/experiments/executions/utils.ts 86.66% <100.00%> (+0.95%) ⬆️
...pipelines/apiHooks/mlmd/useGetEventByArtifactId.ts 90.00% <90.00%> (ø)

... and 39 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f439e5...6147624. Read the comment docs.

@Gkrumbach07
Copy link
Member

@pnaik1 this looks good. however i think we should also add the reference to the pipeline run in the list of references if possible. PMs request was looking to get back to run directly from the artifact

I can go from the run view to an artifact, but I can’t go from an artifact list to which run it was produced by.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality looks good otherwise

@pnaik1
Copy link
Contributor Author

pnaik1 commented Nov 15, 2024

@Gkrumbach07 PMs request was looking to get back to run directly from the artifact
Does this mean to list all the pipeline runs (even runs from cached execution) connected to the artifact or just the root pipeline run which created it
Ex:

Execution-1 -> run-id-1-> artifact-1
Execution-2(cached)->run-id-2-> artifact-1

the artifact details page should look something like this???

Pipeline run.      run-id-1
                   run-id-2

or just original/root runs

Pipeline run. run-id-1

@yannnz
Copy link

yannnz commented Nov 15, 2024

For the cached one, would it be something like this in the screenshot? Under the Reference section, list the Run and execution cached this artifact, then list the original run and execution created this artifact. Root might sounds more accurate than Original , but we name it asOriginal execution under the Execution detail page.

Screenshot 2024-11-15 at 21 42 32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants