Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance visit with login #3469

Conversation

FedeAlonso
Copy link
Contributor

@FedeAlonso FedeAlonso commented Nov 13, 2024

https://issues.redhat.com/browse/RHOAIENG-15671

Description

We are having some issues when trying to use a contributor role user (not an admin one) in the e2e as we depend on an already created test-variables.yml.
That file, has the contributor user stored as TEST_USER_3.

How Has This Been Tested?

Locally, running against a 2.16 RHOAI cluster
image

Test Impact

This is a modification of the way the users log in the tests. So full impact.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 13, 2024
@openshift-ci openshift-ci bot removed the lgtm label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.65%. Comparing base (6f439e5) to head (509d4ce).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3469      +/-   ##
==========================================
- Coverage   85.65%   85.65%   -0.01%     
==========================================
  Files        1347     1347              
  Lines       30676    30676              
  Branches     8554     8554              
==========================================
- Hits        26275    26274       -1     
- Misses       4401     4402       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f439e5...509d4ce. Read the comment docs.

@FedeAlonso FedeAlonso marked this pull request as ready for review November 14, 2024 06:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Nov 14, 2024
Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aace1c2 into opendatahub-io:main Nov 14, 2024
4 checks passed
@FedeAlonso FedeAlonso deleted the fix/enhance_visit_with_login branch November 14, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants