Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upversion dashboard #3467

Conversation

manaswinidas
Copy link
Contributor

No description provided.

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.64%. Comparing base (be095fa) to head (68ff135).
Report is 1 commits behind head on v2.29.0-fixes.

Files with missing lines Patch % Lines
...ens/spawner/connections/ConnectionsFormSection.tsx 36.36% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           v2.29.0-fixes    #3467      +/-   ##
=================================================
- Coverage          85.64%   85.64%   -0.01%     
=================================================
  Files               1347     1347              
  Lines              30669    30676       +7     
  Branches            8550     8554       +4     
=================================================
+ Hits               26267    26271       +4     
- Misses              4402     4405       +3     
Files with missing lines Coverage Δ
...ens/spawner/connections/ConnectionsFormSection.tsx 79.77% <36.36%> (-1.94%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be095fa...68ff135. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit b09ef1b into opendatahub-io:v2.29.0-fixes Nov 13, 2024
4 checks passed
manaswinidas added a commit to red-hat-data-services/odh-dashboard that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants