Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove admin requirement to fetch connection types #3408

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-15217

Description

Connection type GET endpoint was secured behind admin protection. This PR makes it so that a regular user can use this endpoint.

How Has This Been Tested?

  • enable the connection types feature flag disableConnectionTypes
  • As an admin:
  • navigate to Settings -> Connection types
  • observe OOBT connection types listed
  • As a regular user:
  • navigate to project details -> connections tab
  • page loads without error and can create a connection

Test Impact

N/A backend change

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@emilys314
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@23c82ac). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3408   +/-   ##
=======================================
  Coverage        ?   85.88%           
=======================================
  Files           ?     1338           
  Lines           ?    30127           
  Branches        ?     8274           
=======================================
  Hits            ?    25876           
  Misses          ?     4251           
  Partials        ?        0           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c82ac...a512476. Read the comment docs.

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 538a8ff into opendatahub-io:main Oct 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants