Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-10502]: Update App Launcher Title #3406

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Oct 30, 2024

https://issues.redhat.com/browse/RHOAIENG-10502

Changed the header value of the "Applications" section to be "Red Hat Applications" instead of referencing the product name.

The ODH console link no longer appears in the ODH Dashboard application menu therefore no changes were required in this regard cc @manosnoam.

Description

Before:
Screenshot 2024-10-30 at 3 54 43 PM

After:
Screenshot 2024-10-30 at 3 32 45 PM

How Has This Been Tested?

Click on app launcher icon in page masthead.

Test Impact

Updated application.cy.ts.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.88%. Comparing base (1636d39) to head (b54fba8).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3406      +/-   ##
==========================================
+ Coverage   85.12%   85.88%   +0.76%     
==========================================
  Files        1338     1338              
  Lines       30127    30127              
  Branches     8274     8274              
==========================================
+ Hits        25647    25876     +229     
+ Misses       4480     4251     -229     
Files with missing lines Coverage Δ
frontend/src/app/AppLauncher.tsx 69.44% <ø> (ø)

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1636d39...b54fba8. Read the comment docs.

@jenny-s51 jenny-s51 removed the request for review from DaoDaoNoCode October 31, 2024 19:00
@emilys314
Copy link
Contributor

I checked out the PR image and it looks good!
image

/lgtm

@christianvogt
Copy link
Contributor

@andrewballantyne can you have a look at this PR. I don't know the history for product name usage and if we should be avoiding the use of Red Hat outside the context of RHOAI. Although maybe that doesn't matter now.

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope this should be fine. OpenShift Console is a Red Hat product even when they host our ODH Dashboard. We discussed this on the ticket and I wanna say in slack too. I am fairly confident this is a good move forward to keep our consistencies together.

LGTM (from screenshot and code -- didn't run it)

Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 012f82d into opendatahub-io:main Nov 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants