-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-10502]: Update App Launcher Title #3406
[RHOAIENG-10502]: Update App Launcher Title #3406
Conversation
49baea2
to
b54fba8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3406 +/- ##
==========================================
+ Coverage 85.12% 85.88% +0.76%
==========================================
Files 1338 1338
Lines 30127 30127
Branches 8274 8274
==========================================
+ Hits 25647 25876 +229
+ Misses 4480 4251 -229
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@andrewballantyne can you have a look at this PR. I don't know the history for product name usage and if we should be avoiding the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope this should be fine. OpenShift Console is a Red Hat product even when they host our ODH Dashboard. We discussed this on the ticket and I wanna say in slack too. I am fairly confident this is a good move forward to keep our consistencies together.
LGTM (from screenshot and code -- didn't run it)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-10502
Changed the header value of the "Applications" section to be "Red Hat Applications" instead of referencing the product name.
The ODH console link no longer appears in the ODH Dashboard application menu therefore no changes were required in this regard cc @manosnoam.
Description
Before:
After:
How Has This Been Tested?
Click on app launcher icon in page masthead.
Test Impact
Updated
application.cy.ts
.Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main