-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(14691): serving runtime link to args #3400
feat(14691): serving runtime link to args #3400
Conversation
...rc/pages/modelServing/screens/projects/ServingRuntimeModal/ServingRuntimeTemplateSection.tsx
Outdated
Show resolved
Hide resolved
@manaswinidas yes - should be |
bb4bd07
to
1223107
Compare
7b783e4
to
fd1dac7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3400 +/- ##
==========================================
+ Coverage 85.85% 85.91% +0.05%
==========================================
Files 1338 1338
Lines 30267 30280 +13
Branches 8346 8351 +5
==========================================
+ Hits 25987 26015 +28
+ Misses 4280 4265 -15
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @gitdallas!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can possibly simplify this?
frontend/src/pages/modelServing/screens/projects/kServeModal/ManageKServeModal.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: gitdallas <[email protected]>
fd1dac7
to
f4d24bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gitdallas
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley, yih-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes: https://issues.redhat.com/browse/RHOAIENG-14691
Description
no change until serving runtime is selected, at which point a helptext with link shows up:
clicking that link will scroll (if necessary) and focus on the additional args textarea
How Has This Been Tested?
locally
Test Impact
added tests that it doesn't show up initially, until selecting serving runtime
Request review criteria:
should only show up in kserve, with servingRunTimeParamsEnabled, and after selecting a serving runtime
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main