Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(14691): serving runtime link to args #3400

Conversation

gitdallas
Copy link
Contributor

@gitdallas gitdallas commented Oct 29, 2024

closes: https://issues.redhat.com/browse/RHOAIENG-14691

Description

image
no change until serving runtime is selected, at which point a helptext with link shows up:
image
clicking that link will scroll (if necessary) and focus on the additional args textarea
image

How Has This Been Tested?

locally

Test Impact

added tests that it doesn't show up initially, until selecting serving runtime

Request review criteria:

should only show up in kserve, with servingRunTimeParamsEnabled, and after selecting a serving runtime

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@yih-wang
Copy link

@manaswinidas yes - should be You can optimize model performance by configuring the parameters of the selected serving runtime.
@gitdallas ^^

@gitdallas gitdallas force-pushed the feat/14691-serving-runtime-help-text branch 3 times, most recently from bb4bd07 to 1223107 Compare October 31, 2024 13:52
@gitdallas gitdallas force-pushed the feat/14691-serving-runtime-help-text branch 2 times, most recently from 7b783e4 to fd1dac7 Compare October 31, 2024 21:33
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.91%. Comparing base (1cd4f29) to head (f4d24bc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...screens/projects/kServeModal/ManageKServeModal.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3400      +/-   ##
==========================================
+ Coverage   85.85%   85.91%   +0.05%     
==========================================
  Files        1338     1338              
  Lines       30267    30280      +13     
  Branches     8346     8351       +5     
==========================================
+ Hits        25987    26015      +28     
+ Misses       4280     4265      -15     
Files with missing lines Coverage Δ
...vingRuntimeModal/ServingRuntimeTemplateSection.tsx 96.29% <100.00%> (+0.64%) ⬆️
...projects/kServeModal/ServingRuntimeArgsSection.tsx 100.00% <100.00%> (+25.00%) ⬆️
...screens/projects/kServeModal/ManageKServeModal.tsx 94.07% <80.00%> (+0.20%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd4f29...f4d24bc. Read the comment docs.

Copy link

@yih-wang yih-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @gitdallas!

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can possibly simplify this?

@openshift-ci openshift-ci bot removed the lgtm label Nov 1, 2024
@gitdallas gitdallas force-pushed the feat/14691-serving-runtime-help-text branch from fd1dac7 to f4d24bc Compare November 1, 2024 16:22
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gitdallas

@openshift-ci openshift-ci bot added the lgtm label Nov 1, 2024
Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley, yih-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3a8fa6b into opendatahub-io:main Nov 1, 2024
6 checks passed
@gitdallas gitdallas deleted the feat/14691-serving-runtime-help-text branch November 1, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants