Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow copying artifact uri #3399

Merged

Conversation

Gkrumbach07
Copy link
Member

@Gkrumbach07 Gkrumbach07 commented Oct 29, 2024

https://issues.redhat.com/browse/RHOAIENG-14989

Description

makes artifact uri link a a component and sets the href to the uri

How Has This Been Tested?

  1. create a pipeline run with a artifact that lives in s3 (HTML, MARKDOWN, ...)
  2. make sure you right click the link and copy the url. making sure that url is the s3://foobar
  3. make sure left clicking the link opens the artifact in a new tab using the singed url still so actual data is shown. the url from this action will not be the s3 uri

Test Impact

no tests impacted just adding href

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (4842b35) to head (e2866b4).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3399   +/-   ##
=======================================
  Coverage   85.14%   85.15%           
=======================================
  Files        1338     1338           
  Lines       30122    30123    +1     
  Branches     8270     8270           
=======================================
+ Hits        25648    25650    +2     
+ Misses       4474     4473    -1     
Files with missing lines Coverage Δ
...ts/pipelines/content/artifacts/ArtifactUriLink.tsx 90.90% <100.00%> (+0.43%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4842b35...e2866b4. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Oct 30, 2024

tested in a cluster
works as expected
/lgtm

@Gkrumbach07
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9c2d29c into opendatahub-io:main Oct 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants