Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create preview modal for connection types #3379

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Oct 24, 2024

https://issues.redhat.com/browse/RHOAIENG-14754

Description

Adds a preview action to connection types which opens a preview modal with the connection form in read only mode.

image
image

How Has This Been Tested?

  • enable the connection types feature flag disableConnectionTypes
  • navigate to Settings -> Connection types as an admin
  • Create a connection type
  • From the connection type list, open the kebab menu for the connection type and select Preview
  • Observe the preview modal is read only and can be closed

Test Impact

Added cypress test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @simrandhaliw

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (d9788f8) to head (eb17e2c).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3379      +/-   ##
==========================================
+ Coverage   85.08%   85.09%   +0.01%     
==========================================
  Files        1329     1330       +1     
  Lines       29931    29937       +6     
  Branches     8200     8201       +1     
==========================================
+ Hits        25466    25476      +10     
+ Misses       4465     4461       -4     
Files with missing lines Coverage Δ
...rc/concepts/connectionTypes/ConnectionTypeForm.tsx 94.28% <ø> (+5.55%) ⬆️
...ts/connectionTypes/ConnectionTypePreviewDrawer.tsx 100.00% <ø> (ø)
...pts/connectionTypes/ConnectionTypePreviewModal.tsx 100.00% <100.00%> (ø)
.../pages/connectionTypes/ConnectionTypesTableRow.tsx 69.09% <100.00%> (+2.42%) ⬆️
...eens/detail/connections/ManageConnectionsModal.tsx 93.54% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9788f8...eb17e2c. Read the comment docs.

@emilys314
Copy link
Contributor

I tested out the PR image and it all looks good

/lgtm

@christianvogt
Copy link
Contributor Author

Rebased. But also pulled out <Form> from ConnectionTypeForm as you did in your PR so that the Add connection title will now only be shown for the preview drawer and not the modal as per latest mocks.

@emilys314
Copy link
Contributor

Tested again
/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e93d22f into opendatahub-io:main Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants