-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create preview modal for connection types #3379
create preview modal for connection types #3379
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3379 +/- ##
==========================================
+ Coverage 85.08% 85.09% +0.01%
==========================================
Files 1329 1330 +1
Lines 29931 29937 +6
Branches 8200 8201 +1
==========================================
+ Hits 25466 25476 +10
+ Misses 4465 4461 -4
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I tested out the PR image and it all looks good /lgtm |
30752d0
to
9eec342
Compare
9eec342
to
eb17e2c
Compare
Rebased. But also pulled out |
Tested again |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-14754
Description
Adds a preview action to connection types which opens a preview modal with the connection form in read only mode.
How Has This Been Tested?
disableConnectionTypes
Settings -> Connection types
as an adminPreview
Test Impact
Added cypress test.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
cc @simrandhaliw