Add character length limit to both model name and version name

[ppadti]

Closes: RHOAIENG-12844

Description

This PR aims to add character length limit to both model name and version name in Register model and Register version forms. Also to use the given model name for the RegisteredModel and the given version name for both the ModelVersion and the ModelArtifact.

How Has This Been Tested?

1. In model registry, click on Register model.
2. check the helper text "Cannot exceed 128 characters" is under model name and version name field.
3. Try to type in a long string, length greater than 128, you will see an error and it will disable the Register model button.
4. Same goes for Register version form, try to Register a version with lang name and you will see the error in helper text and Register version button will be disabled.
5. For Register version, when we select a model we will have multiple helper text under version name.
   Ref: Doc

Test Impact

Added cypress tests.

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[ppadti]

@yih-wang could you please take a look at the above screenshots?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.91%. Comparing base (96e06a2) to head (d17b4da).
Report is 59 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3377      +/-   ##
==========================================
+ Coverage   85.01%   85.91%   +0.90%     
==========================================
  Files        1327     1339      +12     
  Lines       29770    30296     +526     
  Branches     8149     8365     +216     
==========================================
+ Hits        25308    26029     +721     
+ Misses       4462     4267     -195     

Files with missing lines	Coverage Δ
...elRegistry/screens/RegisterModel/RegisterModel.tsx	100.00% <100.00%> (ø)
...s/RegisterModel/RegistrationCommonFormSections.tsx	95.74% <100.00%> (+0.39%)	⬆️
...pages/modelRegistry/screens/RegisterModel/const.ts	100.00% <100.00%> (ø)
...pages/modelRegistry/screens/RegisterModel/utils.ts	96.66% <100.00%> (+0.51%)	⬆️

... and 167 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e06a2...d17b4da. Read the comment docs.

[yih-wang]

@ppadti thanks for the updates!
I know the new validation guidelines suggest having the char limit displayed as help text under the field. However, looking at how it looks under the version field, I feel it's not conveying the info effectively:

• The current version name is not something that can be validated, so we shouldn't use the multi-condition validation pattern here.
• However, having both help texts displayed as two lines of plain text also feels strange.
• Also, the char limit isn't too important here IMO because a user will rarely touch the 128 char limit. It's basically a mechanism we add to avoid registration failure.
  So I'm wondering are we supposed to always have the char limit displayed as help text, or should it be optional? @angesDing @simrandhaliw

I personally prefer not to display the char limit as help text here (for both model name and version name), but only show the error message when user exceeds the limitation.

[manaswinidas]

@yih-wang I see two help texts in the Create Project modal and both are plain text too.

[yih-wang]

@manaswinidas the two help text in project creation are both conditions to be validated. So they both have that 'dynamic validation status' at the very beginning to show whether the condition is satisfied. However, in our case, current version name is xxx is not a validation condition. We can never tell that when it's satisfied or not. It's just a reference for users to create the next version name. So it doesn't make sense to have it in that 'condition to be validated' format.

I chat with @angesDing and @simrandhaliw offline and they both agree that the char limit is not essential to display as help text in our case. We are likely to make improvements to the guidelines to make sure it's clear that the help text for char limit is optional.

So, @ppadti for both model name and version name, let's remove the char limit as the help text, and only have it as error message when the user input exceeds the char limit. Basically just copy what we have for MR labels. For version name, there could be both help text and error message (see the image below). I'm not sure which one would be on top by default, but I'm fine with both ways. We should just follow PF's default and avoid any customization.

[ppadti]

@manaswinidas the two help text in project creation are both conditions to be validated. So they both have that 'dynamic validation status' at the very beginning to show whether the condition is satisfied. However, in our case, current version name is xxx is not a validation condition. We can never tell that when it's satisfied or not. It's just a reference for users to create the next version name. So it doesn't make sense to have it in that 'condition to be validated' format.

I chat with @angesDing and @simrandhaliw offline and they both agree that the char limit is not essential to display as help text in our case. We are likely to make improvements to the guidelines to make sure it's clear that the help text for char limit is optional.

So, @ppadti for both model name and version name, let's remove the char limit as the help text, and only have it as error message when the user input exceeds the char limit. Basically just copy what we have for MR labels. For version name, there could be both help text and error message (see the image below). I'm not sure which one would be on top by default, but I'm fine with both ways. We should just follow PF's default and avoid any customization.

@yih-wang just wanted a small clarification, here in label we show error icon before error text Label text can't exceed 63 characters

that is missing in img that you shared above. So you want me to keep the error icon before error text under model name and version name field like this:

[ppadti]

oh, in Register version form with icon it looks odd,

so I will go ahead with the error text without error icon as you mentioned above @yih-wang sorry for the confusion here...Thanks!!

[yih-wang]

@ppadti Seems the new guidelines don't include the error icon in the error messages. So I think the error icon we have for label error will also be removed when we apply the new rules across the console.

[ppadti]

@yih-wang I have updated the screenshots, take a look them when you have time.

[manaswinidas]

small nit, otherwise lgtm

[mturley]

Just one nitpick, otherwise looks good. If you disagree with this let me know, we could leave it as-is.

[yih-wang]

LGTM, thanks for the updates, @ppadti !

[mturley]

LGTM, thanks @ppadti !

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitdallas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [mturley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comments were addressed