Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to start/stop notebooks when related image is deleted #3374

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Oct 23, 2024

JIRA: RHOAIENG-14134

Description

Simply remove the detection of image availability to unblock users from starting with a deleted notebook image.
Screenshot 2024-10-23 at 1 14 11 PM

How Has This Been Tested?

  1. Import a custom image in the settings page
  2. Create a workbench with that image
  3. Stop the workbench
  4. Delete the custom image you created at step 1
  5. Go back to the workbench list, and make sure you can still click the start button. (You will definitely get an error when starting, though)

Test Impact

Added a cypress test case to verify the button is enabled even when the notebook image is deleted.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.02%. Comparing base (3b33b2e) to head (6c7b5cc).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3374      +/-   ##
==========================================
- Coverage   85.04%   85.02%   -0.03%     
==========================================
  Files        1329     1329              
  Lines       29930    29927       -3     
  Branches     8206     8204       -2     
==========================================
- Hits        25455    25445      -10     
- Misses       4475     4482       +7     
Files with missing lines Coverage Δ
...rc/pages/projects/notebook/NotebookStateAction.tsx 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b33b2e...6c7b5cc. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, jpuzz0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8658a51 into opendatahub-io:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants