Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-14662] Remove deprecated pipeline v1 types #3372

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Oct 23, 2024

https://issues.redhat.com/browse/RHOAIENG-14662

Description

  • Removed all deprecated pipeline V2 types (9987f08)
  • An additional commit was added specifically for renaming all pipeline things including "V2" or "v2" to be without that specification since there is no longer a need to distinguish from another version. If this change is undesired and we wish to keep the naming conventions as-is, I can revert this commit.

How Has This Been Tested?

Verified dashboard compiles, tests run and basic pipeline/version/run/experiment functionality is unaffected.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 97.08029% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.02%. Comparing base (5ec2127) to head (ad2448c).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...cepts/pipelines/apiHooks/useAllPipelineVersions.ts 75.00% 1 Missing ⚠️
...nd/src/concepts/pipelines/apiHooks/usePipelines.ts 85.71% 1 Missing ⚠️
...tent/createRun/contentSections/PipelineSection.tsx 50.00% 1 Missing ⚠️
...lines/content/experiment/CreateExperimentModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3372      +/-   ##
==========================================
- Coverage   85.03%   85.02%   -0.02%     
==========================================
  Files        1329     1329              
  Lines       29928    29907      -21     
  Branches     8206     8202       -4     
==========================================
- Hits        25450    25427      -23     
- Misses       4478     4480       +2     
Files with missing lines Coverage Δ
...tend/src/concepts/pipelines/apiHooks/mlmd/types.ts 100.00% <ø> (ø)
...s/pipelines/apiHooks/mlmd/useGetArtifactsByRuns.ts 100.00% <100.00%> (ø)
...c/concepts/pipelines/apiHooks/useExperimentById.ts 100.00% <100.00%> (ø)
.../src/concepts/pipelines/apiHooks/useExperiments.ts 100.00% <100.00%> (ø)
...pts/pipelines/apiHooks/useLatestPipelineVersion.ts 100.00% <100.00%> (ø)
...src/concepts/pipelines/apiHooks/usePipelineById.ts 100.00% <100.00%> (ø)
...rc/concepts/pipelines/apiHooks/usePipelineQuery.ts 100.00% <100.00%> (ø)
.../pipelines/apiHooks/usePipelineRecurringRunById.ts 90.00% <100.00%> (ø)
...pts/pipelines/apiHooks/usePipelineRecurringRuns.ts 100.00% <100.00%> (ø)
.../concepts/pipelines/apiHooks/usePipelineRunById.ts 100.00% <100.00%> (ø)
... and 114 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec2127...ad2448c. Read the comment docs.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Tested everything I could think of, didn't find a bug.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, tested and see no issues

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3d11270 into opendatahub-io:main Oct 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants