-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change connection types annotation from enabled to disabled #3363
change connection types annotation from enabled to disabled #3363
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3363 +/- ##
==========================================
+ Coverage 85.01% 85.05% +0.04%
==========================================
Files 1327 1329 +2
Lines 29770 29925 +155
Branches 8149 8202 +53
==========================================
+ Hits 25308 25452 +144
- Misses 4462 4473 +11
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
b.metadata.annotations?.['opendatahub.io/enabled'] !== 'true' | ||
? -1 | ||
: 1; | ||
return a.metadata.annotations?.['opendatahub.io/disabled'] !== 'true' ? -1 : 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a change from before but do we want to sort by name if the enabled state is the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya that's probably a good idea!
2379bfc
to
5e2f8ac
Compare
5e2f8ac
to
ff879bd
Compare
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@christianvogt you can rerun the failed CI github action or rebase and it goes away |
https://issues.redhat.com/browse/RHOAIENG-14749
Description
Replaces annotation
opendatahub.io/enabled
with the inverseopendatahub.io/disabled
.How Has This Been Tested?
disableConnectionType
Settings -> Connection types
Connections
tab.Test Impact
Existing tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main