Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change connection types annotation from enabled to disabled #3363

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-14749

Description

Replaces annotation opendatahub.io/enabled with the inverse opendatahub.io/disabled.

How Has This Been Tested?

  • Enable the connection type feature flag: disableConnectionType
  • Navigate to Settings -> Connection types
  • Create and edit various connection types. Set the enabled checkbox to checked and unchecked.
  • Use the toggle button in the connection types list to toggle the enabled state.
  • Navigate to a project via the project list page.
  • Go to the Connections tab.
  • Create a new connection. Observe that only the enabled connections are present.

Test Impact

Existing tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.05%. Comparing base (96e06a2) to head (ff879bd).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/pages/connectionTypes/columns.ts 57.14% 3 Missing ⚠️
frontend/src/services/connectionTypesService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3363      +/-   ##
==========================================
+ Coverage   85.01%   85.05%   +0.04%     
==========================================
  Files        1327     1329       +2     
  Lines       29770    29925     +155     
  Branches     8149     8202      +53     
==========================================
+ Hits        25308    25452     +144     
- Misses       4462     4473      +11     
Files with missing lines Coverage Δ
...cepts/connectionTypes/createConnectionTypeUtils.ts 100.00% <100.00%> (ø)
frontend/src/concepts/connectionTypes/types.ts 100.00% <ø> (ø)
frontend/src/concepts/connectionTypes/utils.ts 92.48% <100.00%> (-0.97%) ⬇️
.../pages/connectionTypes/ConnectionTypesTableRow.tsx 66.66% <100.00%> (-1.26%) ⬇️
frontend/src/services/connectionTypesService.ts 47.91% <0.00%> (ø)
frontend/src/pages/connectionTypes/columns.ts 46.15% <57.14%> (+1.70%) ⬆️

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e06a2...ff879bd. Read the comment docs.

b.metadata.annotations?.['opendatahub.io/enabled'] !== 'true'
? -1
: 1;
return a.metadata.annotations?.['opendatahub.io/disabled'] !== 'true' ? -1 : 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a change from before but do we want to sort by name if the enabled state is the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya that's probably a good idea!

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Member

@christianvogt you can rerun the failed CI github action or rebase and it goes away

@openshift-merge-bot openshift-merge-bot bot merged commit 09485d2 into opendatahub-io:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants