Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename trusty flag to disableTrustyBiasMetrics #3340

Merged

Conversation

Gkrumbach07
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-14126

Description

renames trusty flag to disableTrustyBiasMetrics and removed logic in the resourceUtils that prevents RHOAI from using the feature flag

How Has This Been Tested?

Make sure enable trusty is visible in the permissions tab

Test Impact

no test impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (ecf36fc) to head (f6a1974).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3340      +/-   ##
==========================================
- Coverage   84.84%   84.84%   -0.01%     
==========================================
  Files        1315     1321       +6     
  Lines       29494    29447      -47     
  Branches     8059     8038      -21     
==========================================
- Hits        25024    24983      -41     
+ Misses       4470     4464       -6     
Files with missing lines Coverage Δ
frontend/src/concepts/areas/const.ts 100.00% <ø> (ø)
frontend/src/k8sTypes.ts 100.00% <ø> (ø)

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf36fc...f6a1974. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Oct 17, 2024

I see the enable trusty is visible in the setting tab
/lgtm

Screenshot 2024-10-17 at 6 08 29 PM

@Gkrumbach07
Copy link
Member Author

/hold

waiting for confirmation from backend that this feature is going GA

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Oct 17, 2024
Copy link
Member Author

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gkrumbach07
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Oct 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 448ed59 into opendatahub-io:main Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants