-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename trusty flag to disableTrustyBiasMetrics #3340
rename trusty flag to disableTrustyBiasMetrics #3340
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
==========================================
- Coverage 84.84% 84.84% -0.01%
==========================================
Files 1315 1321 +6
Lines 29494 29447 -47
Branches 8059 8038 -21
==========================================
- Hits 25024 24983 -41
+ Misses 4470 4464 -6
... and 31 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/hold waiting for confirmation from backend that this feature is going GA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
https://issues.redhat.com/browse/RHOAIENG-14126
Description
renames trusty flag to disableTrustyBiasMetrics and removed logic in the resourceUtils that prevents RHOAI from using the feature flag
How Has This Been Tested?
Make sure enable trusty is visible in the permissions tab
Test Impact
no test impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main