Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #3323 due to errors caused by client-node upgrade #3330

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

alexcreasy
Copy link
Contributor

@alexcreasy alexcreasy commented Oct 14, 2024

Description

Due to errors in MR features caused by PR:

this PR will revert those changes, to restore main to a fully functional condition.

How Has This Been Tested?

NOTE: This PR has NOT been tested in a live cluster yet and as such is on hold until it has.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

…to incompatibilities caused.

This reverts commit 63e8206.
@alexcreasy
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Oct 14, 2024
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified both on localhost and the modelregistry-ui shared cluster.

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley
Copy link
Contributor

mturley commented Oct 14, 2024

/unhold

@openshift-ci openshift-ci bot added approved and removed do-not-merge/hold This PR is hold for some reason labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.82%. Comparing base (6ec1b1b) to head (a4c8d78).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
+ Coverage   84.79%   84.82%   +0.03%     
==========================================
  Files        1315     1315              
  Lines       29491    29491              
  Branches     8056     8056              
==========================================
+ Hits        25006    25017      +11     
+ Misses       4485     4474      -11     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec1b1b...a4c8d78. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit ae66e3b into opendatahub-io:main Oct 14, 2024
8 checks passed
@alexcreasy alexcreasy deleted the revert-pr3323 branch October 15, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants