Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to show tooltip on explore card badges #3328

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Fixes RHOAIENG-7709

Description

Adds z-index to the partner badge for selectable cards so that it shows above the card overlay and displays the tooltip on hover. Adds the pointer cursor and handles the click event when the card is not disabled (so that click on the badge still selects the card).

How Has This Been Tested?

  • On the Explore page, for an enabled card:
    • hover over the badge, verify the tooltip for the badge is shown and the cursor remains the pointer cursor
    • click on the badge, verify the card becomes selected and the side panel shows its details
  • On the Explore page, for disabled card (I tested by forcing cards to be disabled):
    • hover over the badge, verify the tooltip for the badge is shown
    • click on the badge, verify nothing happens

Test Impact

Automated testing is not feasible since it is hover state visuals that have changed

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.81%. Comparing base (6ec1b1b) to head (2d4d8bf).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3328      +/-   ##
==========================================
+ Coverage   84.79%   84.81%   +0.02%     
==========================================
  Files        1315     1315              
  Lines       29491    29491              
  Branches     8056     8056              
==========================================
+ Hits        25006    25013       +7     
+ Misses       4485     4478       -7     
Files with missing lines Coverage Δ
frontend/src/components/OdhExploreCard.tsx 91.66% <100.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec1b1b...2d4d8bf. Read the comment docs.

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on enabled and disabled cards. Tooltip behavior works as expected on selectable cards.

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jenny-s51

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c4ae140 into opendatahub-io:main Oct 15, 2024
8 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the card-badge-tip branch October 16, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants