-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection card update #3309
Connection card update #3309
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
==========================================
- Coverage 84.76% 84.75% -0.01%
==========================================
Files 1309 1309
Lines 29318 29324 +6
Branches 7981 7985 +4
==========================================
+ Hits 24850 24855 +5
- Misses 4468 4469 +1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@ashley-o0o for now we still need to conditionally render the new connection type features behind the feature flag. |
58823d8
to
f1c557e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified against current mocks
/lgtm
f1c557e
to
48615d2
Compare
/lgtm |
48615d2
to
65e4ba5
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Closes: RHOAIENG-13140
Description
Updates the data connections card with new contents on both the home page and the data science projects page. The Connections card on the data science projects page now links to the connections tab.
How Has This Been Tested?
Tested locally
Test Impact
No tests added
Screenshots
----------------------
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main