-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable manage permissions when no rolebinding present for the default group #3306
Disable manage permissions when no rolebinding present for the default group #3306
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3306 +/- ##
==========================================
- Coverage 84.84% 84.81% -0.04%
==========================================
Files 1307 1309 +2
Lines 29238 29329 +91
Branches 7902 7986 +84
==========================================
+ Hits 24808 24874 +66
- Misses 4430 4455 +25
... and 151 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
4324824
to
57fab64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, one small nitpick @ppadti
frontend/src/pages/modelRegistrySettings/ModelRegistriesTableRow.tsx
Outdated
Show resolved
Hide resolved
57fab64
to
0f301f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ppadti !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Closes: RHOAIENG-13091
Description
This PR aims to disable the Manage Permissions when model registry is in not ready state.
How Has This Been Tested?
Create a model registry
when Model registry is in progressing state, Manage permissions on the model registry table will be disabled.
Test Impact
Updated cypress test.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main