-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Trusty DB fields #3305
Support for Trusty DB fields #3305
Conversation
445a472
to
3977117
Compare
3977117
to
b387414
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contextual review comments
frontend/src/concepts/trustyai/context/useDoesTrustyAICRExist.ts
Outdated
Show resolved
Hide resolved
frontend/src/concepts/trustyai/content/useTrustyExistingSecretValidation.ts
Outdated
Show resolved
Hide resolved
Ok I looked over the code and other than what i commented it looks alright. Going to test it live update: tested live and it is looking good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good and works on cluster live. a few things to follow up on after
- if the secret is valid then it will recheck on blur even if no text change
- you are allowed to submit a secret name such as "my-secret ". input says its valid but trusty may or may not think so?
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-13084
Description
Refactored Trusty state as we are getting better status information.
Added DB modal. Screenshots below.
Screenshots
How Has This Been Tested?
?devFeatureFlags
param if you're on a cluster that is disabling trusty for RHOAI)Deploy a DB & connect to it via the Trusty settings in the Project Settings tab.
Steps for mariadb: https://github.com/trustyai-explainability/reference/blob/main/db-connection/README.md
Test Impact
Modal & button state tests -- dropped old checkbox tests (component was removed)
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main