-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update empty pipeline server page button variant #3303
Update empty pipeline server page button variant #3303
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3303 +/- ##
==========================================
+ Coverage 84.80% 84.84% +0.03%
==========================================
Files 1307 1308 +1
Lines 29195 29225 +30
Branches 7883 7893 +10
==========================================
+ Hits 24760 24795 +35
+ Misses 4435 4430 -5
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree i think the card needs to stay as link due to the other cards having their action buttons be link too. The jira was concerned with our full pages not using the primary variant so this lgtm /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dpanshug, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry there was a vpn issue in Beijing office, those comments didn't show up to me in previous days. I think this looks good to me. |
JIRA: https://issues.redhat.com/browse/RHOAIENG-9209
Description
Updated the configure server button variant on pipelines page to make it primary.
How Has This Been Tested?
Go to the project that doesn't have a pipeline server configured, make sure the configure server button is the primary style on both the projects page and the pipelines global page.
Test Impact
N/A, minor UX update.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main