-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dry run all workbench create/update calls before submit #3301
Dry run all workbench create/update calls before submit #3301
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
==========================================
+ Coverage 84.77% 84.89% +0.12%
==========================================
Files 1309 1309
Lines 29292 29275 -17
Branches 7955 7948 -7
==========================================
+ Hits 24831 24854 +23
+ Misses 4461 4421 -40
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
b061316
to
01170cc
Compare
@pnaik1 Nice catch, it's a bug and I updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
this looks good. everything looks to be dry run first now
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: RHOAIENG-1142
Description
Check all the API calls that are executed when creating/updating a workbench, make sure dry run them before truly submitting.
How Has This Been Tested?
test key
(space is not permitted in the key)test-key
xxx already exists
Test Impact
Added a unit test to verify all the networks have dry run options.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main