-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX updates for pipeline logs #3295
UX updates for pipeline logs #3295
Conversation
@yannnz Can you check the screenshots above? |
e309594
to
d143c25
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3295 +/- ##
==========================================
+ Coverage 84.76% 84.77% +0.01%
==========================================
Files 1309 1309
Lines 29318 29321 +3
Branches 7981 7979 -2
==========================================
+ Hits 24850 24858 +8
+ Misses 4468 4463 -5
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@DaoDaoNoCode, wonder what are the sizes of the pause and resume action buttons? It seems a bit smaller. |
Hi @yannnz, the icon is 14x14, which is the same size as the search icon For the second point, what you said is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i expand or un-expand the LogTabStatus the log scrolls to the start. I would expect it to be at the same position. wdyt @yannnz ?
Screen.Recording.2024-10-09.at.7.39.36.PM.mov
@DaoDaoNoCode regarding the pause/resume icon size, i agree with @yannnz that seems a bit smaller to me also. can we increase to |
1f4190c
to
78d7207
Compare
As for the issue you mentioned above @dpanshug, I think it's a known issue in the PF log viewer and a limitation there because everything got rendered dynamically. When the container height changes, it's hard to estimate which line it remained at. |
78d7207
to
3d956d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
tested and works as expected. I am able to highlight and copy without it jumping around
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: https://issues.redhat.com/browse/RHOAIENG-6582
Description
Follow the mockup to do the following updates:
How Has This Been Tested?
Test Impact
N/A, mostly UX updates, and needs manual verification.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main