Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cypress Pipeline e2e test #3281

Merged

Conversation

FedeAlonso
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-13384

Description

After some changes in the DSProjects view search toolbar, the Pipelines e2e test was failing.
Also I've updated the URL used to import the pipeline.

How Has This Been Tested?

cypress/job/dashboard-tests/18
image

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (9372a8a) to head (f4ed998).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3281      +/-   ##
==========================================
- Coverage   84.87%   84.86%   -0.01%     
==========================================
  Files        1306     1306              
  Lines       29201    29201              
  Branches     7888     7888              
==========================================
- Hits        24784    24782       -2     
- Misses       4417     4419       +2     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9372a8a...f4ed998. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fede!

Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Oct 1, 2024
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

New changes are detected. LGTM label has been removed.

@FedeAlonso FedeAlonso added the lgtm label Oct 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2ba600c into opendatahub-io:main Oct 2, 2024
8 checks passed
@FedeAlonso FedeAlonso deleted the fix/e2e_pipelines_test branch October 2, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants